com.unity.netcode.gameobjects@1.0.0-pre.8

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

Additional documentation and release notes are available at [Multiplayer Documentation](https://docs-multiplayer.unity3d.com).

## [1.0.0-pre.8] - 2022-04-27

### Changed

- `unmanaged` structs are no longer universally accepted as RPC parameters because some structs (i.e., structs with pointers in them, such as `NativeList<T>`) can't be supported by the default memcpy struct serializer. Structs that are intended to be serialized across the network must add `INetworkSerializeByMemcpy` to the interface list (i.e., `struct Foo : INetworkSerializeByMemcpy`). This interface is empty and just serves to mark the struct as compatible with memcpy serialization. For external structs you can't edit, you can pass them to RPCs by wrapping them in `ForceNetworkSerializeByMemcpy<T>`. (#1901)

### Removed
- Removed `SIPTransport` (#1870)

- Removed `ClientNetworkTransform` from the package samples and moved to Boss Room's Utilities package which can be found [here](https://github.com/Unity-Technologies/com.unity.multiplayer.samples.coop/blob/main/Packages/com.unity.multiplayer.samples.coop/Utilities/Net/ClientAuthority/ClientNetworkTransform.cs).

### Fixed

- Fixed `NetworkTransform` generating false positive rotation delta checks when rolling over between 0 and 360 degrees. (#1890)
- Fixed client throwing an exception if it has messages in the outbound queue when processing the `NetworkEvent.Disconnect` event and is using UTP. (#1884)
- Fixed issue during client synchronization if 'ValidateSceneBeforeLoading' returned false it would halt the client synchronization process resulting in a client that was approved but not synchronized or fully connected with the server. (#1883)
- Fixed an issue where UNetTransport.StartServer would return success even if the underlying transport failed to start (#854)
- Passing generic types to RPCs no longer causes a native crash (#1901)
- Fixed an issue where calling `Shutdown` on a `NetworkManager` that was already shut down would cause an immediate shutdown the next time it was started (basically the fix makes `Shutdown` idempotent). (#1877)

Tests/Runtime/StopStartRuntimeTests.cs

@@ -6,69 +6,75 @@ using Unity.Netcode.TestHelpers.Runtime;
 
 namespace Unity.Netcode.RuntimeTests
 {
-    public class StopStartRuntimeTests
+    public class StopStartRuntimeTests : NetcodeIntegrationTest
     {
+        protected override int NumberOfClients => 1;
+
+        protected override void OnOneTimeSetup()
+        {
+            m_UseHost = false;
+            base.OnOneTimeSetup();
+        }
+
         [UnityTest]
         public IEnumerator WhenShuttingDownAndRestarting_SDKRestartsSuccessfullyAndStaysRunning()
-        {            // create server and client instances
-            NetcodeIntegrationTestHelpers.Create(1, out NetworkManager server, out NetworkManager[] clients);
+        {
+            // shutdown the server
+            m_ServerNetworkManager.Shutdown();
 
-            try
-            {
+            // wait 1 frame because shutdowns are delayed
+            var nextFrameNumber = Time.frameCount + 1;
+            yield return new WaitUntil(() => Time.frameCount >= nextFrameNumber);
 
-                // create prefab
-                var gameObject = new GameObject("PlayerObject");
-                var networkObject = gameObject.AddComponent<NetworkObject>();
-                networkObject.DontDestroyWithOwner = true;
-                NetcodeIntegrationTestHelpers.MakeNetworkObjectTestPrefab(networkObject);
+            // Verify the shutdown occurred
+            Assert.IsFalse(m_ServerNetworkManager.IsServer);
+            Assert.IsFalse(m_ServerNetworkManager.IsListening);
+            Assert.IsFalse(m_ServerNetworkManager.IsHost);
+            Assert.IsFalse(m_ServerNetworkManager.IsClient);
 
-                server.NetworkConfig.PlayerPrefab = gameObject;
+            m_ServerNetworkManager.StartServer();
+            // Verify the server started
+            Assert.IsTrue(m_ServerNetworkManager.IsServer);
+            Assert.IsTrue(m_ServerNetworkManager.IsListening);
 
-                for (int i = 0; i < clients.Length; i++)
-                {
-                    clients[i].NetworkConfig.PlayerPrefab = gameObject;
-                }
+            // Wait several frames / one full network tick
+            yield return s_DefaultWaitForTick;
 
-                // start server and connect clients
-                NetcodeIntegrationTestHelpers.Start(false, server, clients);
+            // Verify the server is still running
+            Assert.IsTrue(m_ServerNetworkManager.IsServer);
+            Assert.IsTrue(m_ServerNetworkManager.IsListening);
+        }
 
-                // wait for connection on client side
-                yield return NetcodeIntegrationTestHelpers.WaitForClientsConnected(clients);
+        [UnityTest]
+        public IEnumerator WhenShuttingDownTwiceAndRestarting_SDKRestartsSuccessfullyAndStaysRunning()
+        {
+            // shutdown the server
+            m_ServerNetworkManager.Shutdown();
 
-                // wait for connection on server side
-                yield return NetcodeIntegrationTestHelpers.WaitForClientConnectedToServer(server);
+            // wait 1 frame because shutdowns are delayed
+            var nextFrameNumber = Time.frameCount + 1;
+            yield return new WaitUntil(() => Time.frameCount >= nextFrameNumber);
 
-                // shutdown the server
-                server.Shutdown();
+            // Verify the shutdown occurred
+            Assert.IsFalse(m_ServerNetworkManager.IsServer);
+            Assert.IsFalse(m_ServerNetworkManager.IsListening);
+            Assert.IsFalse(m_ServerNetworkManager.IsHost);
+            Assert.IsFalse(m_ServerNetworkManager.IsClient);
 
-                // wait 1 frame because shutdowns are delayed
-                var nextFrameNumber = Time.frameCount + 1;
-                yield return new WaitUntil(() => Time.frameCount >= nextFrameNumber);
+            // Shutdown the server again.
+            m_ServerNetworkManager.Shutdown();
 
-                // Verify the shutdown occurred
-                Assert.IsFalse(server.IsServer);
-                Assert.IsFalse(server.IsListening);
-                Assert.IsFalse(server.IsHost);
-                Assert.IsFalse(server.IsClient);
+            m_ServerNetworkManager.StartServer();
+            // Verify the server started
+            Assert.IsTrue(m_ServerNetworkManager.IsServer);
+            Assert.IsTrue(m_ServerNetworkManager.IsListening);
 
-                server.StartServer();
-                // Verify the server started
-                Assert.IsTrue(server.IsServer);
-                Assert.IsTrue(server.IsListening);
+            // Wait several frames / one full network tick
+            yield return s_DefaultWaitForTick;
 
-                // Wait several frames
-                nextFrameNumber = Time.frameCount + 10;
-                yield return new WaitUntil(() => Time.frameCount >= nextFrameNumber);
-
-                // Verify the server is still running
-                Assert.IsTrue(server.IsServer);
-                Assert.IsTrue(server.IsListening);
-            }
-            finally
-            {
-                // cleanup
-                NetcodeIntegrationTestHelpers.Destroy();
-            }
+            // Verify the server is still running
+            Assert.IsTrue(m_ServerNetworkManager.IsServer);
+            Assert.IsTrue(m_ServerNetworkManager.IsListening);
         }
     }
 }